2026-06-03 19:19:34 +02:00
|
|
|
"""Tests for HAClient using unittest.mock to avoid aioresponses/aiohttp version coupling."""
|
2026-05-29 12:26:34 +02:00
|
|
|
from __future__ import annotations
|
|
|
|
|
|
2026-06-03 19:19:34 +02:00
|
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
|
|
2026-05-29 12:26:34 +02:00
|
|
|
import pytest
|
|
|
|
|
|
2026-05-29 13:41:55 +02:00
|
|
|
from ha_diag.ha_client import HAClient, make_session
|
2026-05-29 12:26:34 +02:00
|
|
|
|
|
|
|
|
HA_URL = "http://homeassistant.test:8123"
|
|
|
|
|
TOKEN = "test-token"
|
|
|
|
|
|
|
|
|
|
|
2026-06-03 19:19:34 +02:00
|
|
|
def _mock_resp(payload=None, text=None, status=200):
|
|
|
|
|
"""Return a mock that behaves like an aiohttp response context manager."""
|
|
|
|
|
resp = MagicMock()
|
|
|
|
|
resp.status = status
|
|
|
|
|
if status >= 400:
|
|
|
|
|
resp.raise_for_status.side_effect = Exception(f"HTTP {status}")
|
|
|
|
|
else:
|
|
|
|
|
resp.raise_for_status = MagicMock()
|
|
|
|
|
resp.json = AsyncMock(return_value=payload if payload is not None else {})
|
|
|
|
|
resp.text = AsyncMock(return_value=text or "")
|
|
|
|
|
resp.__aenter__ = AsyncMock(return_value=resp)
|
|
|
|
|
resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
|
return resp
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def _mock_session(get_resp=None):
|
|
|
|
|
session = MagicMock()
|
|
|
|
|
session.get.return_value = get_resp or _mock_resp()
|
|
|
|
|
return session
|
|
|
|
|
|
|
|
|
|
|
2026-05-29 12:26:34 +02:00
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_api_status_ok():
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp({"message": "API running."}))
|
|
|
|
|
client = HAClient(HA_URL, session)
|
|
|
|
|
result = await client.get_api_status()
|
2026-05-29 12:26:34 +02:00
|
|
|
assert result == {"message": "API running."}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_api_status_unauthorized():
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(status=401))
|
|
|
|
|
client = HAClient(HA_URL, session)
|
|
|
|
|
with pytest.raises(Exception):
|
|
|
|
|
await client.get_api_status()
|
2026-05-29 12:26:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_states_returns_list():
|
|
|
|
|
payload = [{"entity_id": "light.living_room", "state": "on"}]
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
client = HAClient(HA_URL, session)
|
|
|
|
|
states = await client.get_states()
|
2026-05-29 12:26:34 +02:00
|
|
|
assert isinstance(states, list)
|
|
|
|
|
assert states[0]["entity_id"] == "light.living_room"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_config_returns_dict():
|
|
|
|
|
payload = {"version": "2024.1.0", "location_name": "Home"}
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
client = HAClient(HA_URL, session)
|
|
|
|
|
config = await client.get_config()
|
2026-05-29 12:26:34 +02:00
|
|
|
assert config["version"] == "2024.1.0"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
2026-05-29 13:41:55 +02:00
|
|
|
async def test_get_entity_registry_returns_list():
|
|
|
|
|
payload = [
|
|
|
|
|
{"entity_id": "light.hall", "platform": "zha", "area_id": "hallway"},
|
|
|
|
|
{"entity_id": "sensor.temp", "platform": "mqtt", "area_id": None},
|
|
|
|
|
]
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
client = HAClient(HA_URL, session)
|
|
|
|
|
registry = await client.get_entity_registry()
|
2026-05-29 13:41:55 +02:00
|
|
|
assert len(registry) == 2
|
|
|
|
|
assert registry[0]["platform"] == "zha"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_make_session_sets_auth_header():
|
|
|
|
|
"""make_session injects the Bearer token in all requests."""
|
2026-06-03 19:19:34 +02:00
|
|
|
async with make_session("my-secret-token") as session:
|
2026-05-29 13:41:55 +02:00
|
|
|
assert session.headers.get("Authorization") == "Bearer my-secret-token"
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
# Entity registry TTL cache (Phase 3 Flag #3)
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_entity_registry_cached_on_second_call():
|
|
|
|
|
"""Second call within TTL returns cache, making only one HTTP request."""
|
|
|
|
|
payload = [{"entity_id": "light.hall", "platform": "zha", "area_id": "hallway"}]
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
client = HAClient(HA_URL, session, entity_registry_cache_ttl=300.0)
|
|
|
|
|
r1 = await client.get_entity_registry()
|
|
|
|
|
r2 = await client.get_entity_registry() # from cache
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
assert r1 == r2
|
2026-06-03 19:19:34 +02:00
|
|
|
session.get.assert_called_once() # only one HTTP request
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
2026-06-03 19:19:34 +02:00
|
|
|
async def test_entity_registry_cache_bypassed_after_ttl():
|
|
|
|
|
"""After TTL expiry (ttl=0), next call fetches fresh data."""
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
payload = [{"entity_id": "light.hall", "platform": "zha", "area_id": "hallway"}]
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
# TTL=0 means every call is stale → two fetches
|
|
|
|
|
session.get.side_effect = [_mock_resp(payload), _mock_resp(payload)]
|
|
|
|
|
client = HAClient(HA_URL, session, entity_registry_cache_ttl=0.0)
|
|
|
|
|
await client.get_entity_registry()
|
|
|
|
|
await client.get_entity_registry()
|
|
|
|
|
assert session.get.call_count == 2
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_invalidate_registry_cache_forces_refetch():
|
|
|
|
|
"""invalidate_registry_cache() makes the next call hit the network."""
|
|
|
|
|
payload = [{"entity_id": "light.hall", "platform": "zha", "area_id": ""}]
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session(_mock_resp(payload))
|
|
|
|
|
session.get.side_effect = [_mock_resp(payload), _mock_resp(payload)]
|
|
|
|
|
client = HAClient(HA_URL, session, entity_registry_cache_ttl=300.0)
|
|
|
|
|
await client.get_entity_registry()
|
|
|
|
|
client.invalidate_registry_cache()
|
|
|
|
|
await client.get_entity_registry()
|
|
|
|
|
assert session.get.call_count == 2
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_entity_registry_cache_default_ttl_is_300():
|
2026-06-03 19:19:34 +02:00
|
|
|
session = _mock_session()
|
|
|
|
|
client = HAClient(HA_URL, session)
|
feat(ha-diag-agent): three REST diagnostic checks + Phase 3 flag fixes
New checks:
- SystemHealthCheck (15min interval): detects newly-failing HA
integrations via /api/system_health snapshot diff; transition-based
dedup (ok→error fires, sustained error silent, error→ok clears alert)
- UpdatesAvailableCheck (daily cron 09:00): per-update ha_update_available
events with 7-day dedup; release notes truncated at 2000 chars
- UpdatesDigestCheck (Sunday cron 09:00): single digest event with all
pending updates; weekly ISO-week dedup, independent of daily dedup key
- AutomationFailuresCheck (30min interval): detects automations with
N consecutive failures (default 3) via /api/trace/automation/<id>;
6h cooldown per automation
Phase 3 flag fixes:
- Flag #1 (since field): UnavailableEntitiesCheck now uses
min(state.last_changed, baseline.first_seen) as effective "since",
giving accurate duration when agent was offline at entity's first fail
- Flag #3 (registry cache): HAClient.get_entity_registry() caches
response in-process with configurable TTL (default 300s); avoids
repeated API calls across concurrent check cycles; invalidate_registry_cache()
for manual invalidation
Storage: system_health_snapshot table (component, last_status, last_seen_at,
payload) created automatically on next Storage.open() call
Config additions (all with defaults): entity_registry_cache_ttl=300,
system_health_check_interval=900, automation_check_interval=1800,
automation_failure_threshold=3, updates_check_hour=9,
updates_check_minute=0, updates_cooldown_days=7
Tests: 95 unit tests pass (49 new), 13 integration tests pass (9 new);
3 skipped (live-HA token not set in CI)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-29 14:43:10 +02:00
|
|
|
assert client._registry_cache_ttl == 300.0
|